Support Import Statements - WIP#77
Closed
Cmdv wants to merge 1 commit intoquintenkasteel:new-astfrom
Cmdv:support-import
Closed
Support Import Statements - WIP#77Cmdv wants to merge 1 commit intoquintenkasteel:new-astfrom Cmdv:support-import
Cmdv wants to merge 1 commit intoquintenkasteel:new-astfrom
Cmdv:support-import
Conversation
Collaborator
|
It would be best of this had tests. There are also a couple of warnings in the Travis builds that really should be fixed. |
Author
|
yeah totally sorry it's a WIP to get some feedback. just looking at the specs and I don't seem to cove everything but some of the cases I'm not too sure how to deal with: the |
Collaborator
|
I'd say get what you can working and passing tests and then the rest can be dealt with on an as needed basis. |
5 tasks
hdgarrood
added a commit
to hdgarrood/language-javascript
that referenced
this pull request
Feb 15, 2019
This commit adds support for all forms of the ES module import statement apart from the dynamic 'import()' form and the bare 'import "mod";' form (where the import is only being performed for the sake of some side effects). Supercedes quintenkasteel#77, refs quintenkasteel#71.
hdgarrood
added a commit
to hdgarrood/language-javascript
that referenced
this pull request
Feb 15, 2019
This commit adds support for all forms of the ES module import statement apart from the dynamic 'import()' form and the bare 'import "mod";' form (where the import is only being performed for the sake of some side effects). Supercedes quintenkasteel#77, refs quintenkasteel#71.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of #71
I'm not sure if it needed tests in
Minify.hs+RoundTrip.hsalso I'm wondering if this needs supports all the import specs